Review

Detector:	MuDetectOPAL_180330
Target:	project ' itext ' version 5091
Misuse:	misuse ' dmmc-61 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	On line 1599, `Iterator.next()` is invoked without prior check that there are sufficiently many elements. (Same finding as `mudetect-1` and `mudetectxp-1`)
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/itextpdf/awt/PdfGraphics2D.java
In Method:	drawImage(Image, Image, AffineTransform, Color, ImageObserver)
Code with Misuse:	class PdfGraphics2D { private boolean drawImage(Image img, Image mask, AffineTransform xform, Color bgColor, ImageObserver obs) { if (xform==null) xform = new AffineTransform(); else xform = new AffineTransform(xform); xform.translate(0, img.getHeight(obs)); xform.scale(img.getWidth(obs), img.getHeight(obs)); AffineTransform inverse = this.normalizeMatrix(); AffineTransform flipper = AffineTransform.getScaleInstance(1,-1); inverse.concatenate(xform); inverse.concatenate(flipper); double[] mx = new double[6]; inverse.getMatrix(mx); if (currentFillGState != 255) { PdfGState gs = fillGState[255]; if (gs == null) { gs = new PdfGState(); gs.setFillOpacity(1); fillGState[255] = gs; } cb.setGState(gs); } try { com.itextpdf.text.Image image = null; if(!convertImagesToJPEG){ image = com.itextpdf.text.Image.getInstance(img, bgColor); } else{ BufferedImage scaled = new BufferedImage(img.getWidth(null), img.getHeight(null), BufferedImage.TYPE_INT_RGB); Graphics2D g3 = scaled.createGraphics(); g3.drawImage(img, 0, 0, img.getWidth(null), img.getHeight(null), null); g3.dispose(); ByteArrayOutputStream baos = new ByteArrayOutputStream(); ImageWriteParam iwparam = new JPEGImageWriteParam(Locale.getDefault()); iwparam.setCompressionMode(ImageWriteParam.MODE_EXPLICIT); iwparam.setCompressionQuality(jpegQuality);//Set here your compression rate ImageWriter iw = ImageIO.getImageWritersByFormatName("jpg").next(); ImageOutputStream ios = ImageIO.createImageOutputStream(baos); iw.setOutput(ios); iw.write(null, new IIOImage(scaled, null, null), iwparam); iw.dispose(); ios.close(); scaled.flush(); scaled = null; image = com.itextpdf.text.Image.getInstance(baos.toByteArray()); } if (mask!=null) { com.itextpdf.text.Image msk = com.itextpdf.text.Image.getInstance(mask, null, true); msk.makeMask(); msk.setInverted(true); image.setImageMask(msk); } cb.addImage(image, (float)mx[0], (float)mx[1], (float)mx[2], (float)mx[3], (float)mx[4], (float)mx[5]); Object url = getRenderingHint(HyperLinkKey.KEY_INSTANCE); if (url != null && !url.equals(HyperLinkKey.VALUE_HYPERLINKKEY_OFF)) { PdfAction action = new PdfAction(url.toString()); cb.setAction(action, (float)mx[4], (float)mx[5], (float)(mx[0]+mx[4]), (float)(mx[3]+mx[5])); } } catch (Exception ex) { throw new IllegalArgumentException(ex); } if (currentFillGState != 255) { PdfGState gs = fillGState[currentFillGState]; cb.setGState(gs); } return true; } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
?	6	0.06349206349206349	(pattern support = 20 / 35)(pattern violations = 1 / 3)(overlap = 3.00 / 9.00)	itext/5091/build/src/main/java//com/itextpdf/text/Phrase.java#addAll(Collection) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfPKCS7.java#verifyCertificate(X509Certificate, Collection, Calendar) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfWriter.java#addSharedObjectsToBody() itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfPKCS7.java#getEncodedPKCS7(byte[], Calendar, TSAClient, byte[]) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfSignatureAppearance.java#preClose(HashMap)	20
?	754	0.003741496598639456	(pattern support = 11 / 35)(pattern violations = 1 / 70)(overlap = 5.00 / 6.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/Base64.java#encodeObject(Serializable, int) itext/5091/build/src/main/java//com/itextpdf/text/pdf/RandomAccessFileOrArray.java#<init>(String, boolean, boolean) itext/5091/build/src/main/java//com/itextpdf/text/pdf/RandomAccessFileOrArray.java#<init>(URL) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfSigGenericPKCS.java#setSignInfo(PrivateKey, Certificate[], CRL[]) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/JBIG2SegmentReader.java#getData(boolean)	11
?	5540	0.0004884004884004884	(pattern support = 10 / 35)(pattern violations = 1 / 117)(overlap = 1.00 / 5.00)	itext/5091/build/src/main/java//com/itextpdf/awt/geom/gl/Crossing.java#addBound(double[], int, double[], int, double, double, boolean, int) itext/5091/build/src/main/java//com/itextpdf/awt/geom/gl/Crossing.java#intersectQuad(double, double, double, double, double, double, double, double, double, double) itext/5091/build/src/main/java//com/itextpdf/awt/geom/CubicCurve2D.java#subdivide(double[], int, double[], int, double[], int) itext/5091/build/src/main/java//com/itextpdf/awt/geom/QuadCurve2D.java#subdivide(double[], int, double[], int, double[], int)	10
?	5541	0.0004884004884004884	(pattern support = 10 / 35)(pattern violations = 1 / 117)(overlap = 1.00 / 5.00)	itext/5091/build/src/main/java//com/itextpdf/awt/geom/gl/Crossing.java#addBound(double[], int, double[], int, double, double, boolean, int) itext/5091/build/src/main/java//com/itextpdf/awt/geom/gl/Crossing.java#intersectQuad(double, double, double, double, double, double, double, double, double, double) itext/5091/build/src/main/java//com/itextpdf/awt/geom/CubicCurve2D.java#subdivide(double[], int, double[], int, double[], int) itext/5091/build/src/main/java//com/itextpdf/awt/geom/QuadCurve2D.java#subdivide(double[], int, double[], int, double[], int)	10
?	10879	0.00004545652050389889	(pattern support = 17 / 35)(pattern violations = 1 / 1583)(overlap = 8.00 / 54.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfName.java#<init>(String, boolean) itext/5091/build/src/main/java//com/itextpdf/text/pdf/IntHashtable.java#<init>(int, float) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfShading.java#setBBox(float[]) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/TIFFDirectory.java#<init>(RandomAccessFileOrArray, int) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/TIFFDirectory.java#<init>(RandomAccessFileOrArray, long, int)	17	The graph contained more than 40 nodes (50) and is likely unreadable. Skipping generation.
?	15441	0.00003347560465310904	(pattern support = 18 / 35)(pattern violations = 1 / 1707)(overlap = 5.00 / 45.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfName.java#<init>(String, boolean) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfFileSpecification.java#fileEmbedded(PdfWriter, String, String, byte[], String, PdfDictionary, int) itext/5091/build/src/main/java//com/itextpdf/text/pdf/TrueTypeFontSubSet.java#createTableDirectory() itext/5091/build/src/main/java//com/itextpdf/text/pdf/IntHashtable.java#<init>(int, float) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfNumber.java#<init>(String)	18	The graph contained more than 40 nodes (43) and is likely unreadable. Skipping generation.