Review

finding-0

org/bouncycastle/jsse/provider/

engineInit(KeyStore, char[])

class ProvKeyManagerFactorySpi
    extends KeyManagerFactorySpi
{
    // at the moment we're only accepting X.509/PKCS#8 key material so there is only one key manager needed
    KeyManager keyManager;

    protected void engineInit(KeyStore ks, char[] ksPassword)
        throws KeyStoreException, NoSuchAlgorithmException, UnrecoverableKeyException
    {
        try
        {
            if (ks == null)
            {
                ksPassword = null;

                String ksType = PropertyUtils.getSystemProperty("javax.net.ssl.keyStoreType");
                if (ksType == null)
                {
                    ksType = KeyStore.getDefaultType();
                }

                String ksProv = PropertyUtils.getSystemProperty("javax.net.ssl.keyStoreProvider");
                ks = (ksProv == null || ksProv.length() < 1)
                    ?   KeyStore.getInstance(ksType)
                    :   KeyStore.getInstance(ksType, ksProv);

                String ksPath = null;

                String ksPathProp = PropertyUtils.getSystemProperty("javax.net.ssl.keyStore");
                if (ksPathProp != null)
                {
                    if (new File(ksPathProp).exists())
                    {
                        ksPath = ksPathProp;

                        String ksPasswordProp = PropertyUtils.getSystemProperty("javax.net.ssl.keyStorePassword");
                        if (ksPasswordProp != null)
                        {
                            ksPassword = ksPasswordProp.toCharArray();
                        }
                    }
                }

                if (ksPath == null)
                {
                    ks.load(null, null);
                }
                else
                {
                    InputStream tsInput = new BufferedInputStream(new FileInputStream(ksPath));
                    ks.load(tsInput, ksPassword);
                    tsInput.close();
                }
            }

            keyManager = new ProvX509KeyManagerSimple(ks, ksPassword);
        }
        catch (Exception e)
        {
            throw new KeyStoreException("initialization failed", e);
        }
    }