Review

finding-12

org/uberfire/server/UberfireImageServlet.java

doGet(HttpServletRequest, HttpServletResponse)

class UberfireImageServlet {
    @Override
    protected void doGet(final HttpServletRequest request,
                         final HttpServletResponse response) throws ServletException,
                                                            IOException {
        final String imageUrl = request.getParameter( "url" );
        if ( imageUrl == null ) {
            response.setStatus( HttpServletResponse.SC_NOT_FOUND );
            return;
        }
        final String imageFormat = getImageSuffix( imageUrl );
        byte[] imageData = readImageData( request, imageUrl );
        if ( imageData == null ) {
            response.setStatus( HttpServletResponse.SC_NOT_FOUND );
            return;
        }

        if ( imageFormat != null ) {
            response.setContentType( "image/" + imageFormat );
        }
        response.getOutputStream().write( imageData,
                                          0,
                                          imageData.length );
    }

}