Review

A string is converted to bytes without specifying an explicit encoding. The bytes are then passed to Cipher.doFinal(). The fix specifies the encoding "UTF-8".

• missing/call
• superfluous/call

org/compiere/util/Secure.java

encrypt(String)

class Secure {
	/**
	 *	Encryption.
	 *  @param value clear value
	 *  @return encrypted String
	 */
	public String encrypt (String value)
	{
		String clearText = value;
		if (clearText == null)
			clearText = "";
		//	Init
		if (m_cipher == null)
			initCipher();
		//	Encrypt
		if (m_cipher != null)
		{
			try
			{
				m_cipher.init(Cipher.ENCRYPT_MODE, m_key);
				byte[] encBytes = m_cipher.doFinal(clearText.getBytes());
				String encString = convertToHexString(encBytes);
				// globalqss - [ 1577737 ] Security Breach - show database password
				// log.log (Level.ALL, value + " => " + encString);
				return encString;
			}
			catch (Exception ex)
			{
				// log.log(Level.INFO, value, ex);
				log.log(Level.INFO, "Problem encrypting string", ex);
			}
		}
		//	Fallback
		return CLEARVALUE_START + value + CLEARVALUE_END;
	}	//	encrypt

}

class SpecifyEncryptEncoding {
  void pattern(String clearText) throws UnsupportedEncodingException {
    clearText.getBytes("UTF8");
  }
}