Review

Misses to check File.exists()/File.mkdirs() before calling File.createNewFile().

• missing/condition/value_or_state

org/apache/lucene/store/FSDirectory.java

obtain()

class FSDirectory {
      public boolean obtain() throws IOException {
        if (DISABLE_LOCKS)
          return true;
        return lockFile.createNewFile();
      }

}

class EnsureDirectoryExistsBeforeCreateFile {
  void pattern(File lockDir, String lockFilename) throws IOException {
    File lockFile = new File(lockDir, lockFilename);
    if (!lockDir.exists()) {
      if (!lockDir.mkdirs()) {
        throw new IOException("Cannot create lock directory: " + lockDir);
      }
    }
    lockFile.createNewFile();
  }
}