Review

Detector:

Tikanga

Target:

project '

itext

' version

5091

Tags:

Potential Misuse

Anomaly identified by the detector. Please review whether this anomaly corresponds to a misuse.

Finding:	13
In File:	com/itextpdf/text/pdf/PdfAnnotation.java
In Method:	setMKIconFit(PdfName, PdfName, float, float, boolean)
Code with Finding:	class PdfAnnotation { public void setMKIconFit(PdfName scale, PdfName scalingType, float leftoverLeft, float leftoverBottom, boolean fitInBounds) { PdfDictionary dic = new PdfDictionary(); if (!scale.equals(PdfName.A)) dic.put(PdfName.SW, scale); if (!scalingType.equals(PdfName.P)) dic.put(PdfName.S, scalingType); if (leftoverLeft != 0.5f \|\| leftoverBottom != 0.5f) { PdfArray array = new PdfArray(new PdfNumber(leftoverLeft)); array.add(new PdfNumber(leftoverBottom)); dic.put(PdfName.A, array); } if (fitInBounds) dic.put(PdfName.FB, PdfBoolean.PDFTRUE); getMK().put(PdfName.IF, dic); } }

Metadata

Hit	Rank	Confidence	Defect Indicator	Missing Properties	Present Properties	Supporting Objects	Violation Types
No	13	0.95	19.81	AG (PdfArray. () : void @ (0) => EX EF PdfArray.add (PdfObject) : boolean @ (0));AF PdfArray. () : void @ (0);AG (PdfArray. () : void @ (0) => AX AF PdfDictionary.put (PdfName, PdfObject) : void @ (2));EF PdfArray. () : void @ (0);AG (PdfArray. () : void @ (0) => EX EF PdfDictionary.put (PdfName, PdfObject) : void @ (2))	AF PdfDictionary.put (PdfName, PdfObject) : void @ (2);EF PdfArray.add (PdfObject) : boolean @ (0);AG (PdfArray.add (PdfObject) : boolean @ (0) => EX EF PdfDictionary.put (PdfName, PdfObject) : void @ (2));AG (PdfArray.add (PdfObject) : boolean @ (0) => AX AF PdfDictionary.put (PdfName, PdfObject) : void @ (2));EF PdfDictionary.put (PdfName, PdfObject) : void @ (2)	PdfCopy$PageStamp.alterContents () : void : var #12@PdfArray (line 604);PdfCopyFieldsImp.branchForm (HashMap, PdfIndirectReference, String) : PdfArray : var #25@PdfArray (line 300);PdfCopyFieldsImp.createAcroForms () : void : var #19@PdfArray (line 341)

Reviewer Name:	sven
Comment:	I think the entire use is there (lines 755-757), but it uses another constructor (with one parameter), which is why all the properties are missing.