Review

Detector:	Tikanga
Target:	project ' itext ' version 5091
Misuse:	misuse ' jadet-5 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	PdfArray.getPdfObject() is invoked without checking that the array contains sufficiently many objects.
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/itextpdf/text/pdf/PdfStructureTreeRoot.java
In Method:	nodeProcess(PdfDictionary, PdfIndirectReference)
Code with Misuse:	class PdfStructureTreeRoot { private void nodeProcess(PdfDictionary struc, PdfIndirectReference reference) throws IOException { PdfObject obj = struc.get(PdfName.K); if (obj != null && obj.isArray() && !(((PdfArray)obj).getPdfObject(0)).isNumber()) { PdfArray ar = (PdfArray)obj; for (int k = 0; k < ar.size(); ++k) { PdfStructureElement e = (PdfStructureElement)ar.getAsDict(k); ar.set(k, e.getReference()); nodeProcess(e, e.getReference()); } } if (reference != null) writer.addToBody(struc, reference); } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Defect Indicator	Missing Properties	Present Properties	Supporting Objects
?	11	0.97	20.0	AG (PdfArray.getPdfObject (int) : PdfObject @ (0) => EX EF PdfArray.getPdfObject (int) : PdfObject @ (0))	AG (PdfArray.getPdfObject (int) : PdfObject @ (0) => EX EF PdfArray.size () : int @ (0));AG (PdfArray.getPdfObject (int) : PdfObject @ (0) => AX AF PdfArray.size () : int @ (0));EF PdfArray.size () : int @ (0);EF PdfArray.getPdfObject (int) : PdfObject @ (0);AF PdfArray.size () : int @ (0);AG (PdfArray.size () : int @ (0) => EX EF PdfArray.size () : int @ (0))	DocumentFont.doType1TT () : void : var #26@PdfArray (line 315);AcroFields.getAppearance (PdfDictionary, String[], String) : PdfAppearance : var #18@PdfArray (line 738);DocumentFont.readWidths (PdfArray) : IntHashtable : param #1@PdfArray
?	21	0.95	16.06	AG (PdfArray.getPdfObject (int) : PdfObject @ (0) => EX EF PdfArray.getPdfObject (int) : PdfObject @ (0));AG (CAST: PdfArray => EX EF PdfArray.getPdfObject (int) : PdfObject @ (0))	AG (PdfArray.getPdfObject (int) : PdfObject @ (0) => EX EF PdfArray.size () : int @ (0));AF CAST: PdfArray;AG (PdfArray.getPdfObject (int) : PdfObject @ (0) => AX AF PdfArray.size () : int @ (0));EF PdfArray.size () : int @ (0);AG (CAST: PdfArray => AX AF PdfArray.size () : int @ (0));EF CAST: PdfArray;EF PdfArray.getPdfObject (int) : PdfObject @ (0);AF PdfArray.size () : int @ (0);AG (CAST: PdfArray => EX EF PdfArray.size () : int @ (0))	DocumentFont.readWidths (PdfArray) : IntHashtable : var #5@PdfObject (line 174);PdfNameTree.iterateItems (PdfDictionary, HashMap) : void : var #6@PdfObject (line 143);PdfNameTree.iterateItems (PdfDictionary, HashMap) : void : var #3@PdfObject (line 136)